Skip to content

Add summary to action runs view#36883

Merged
wxiaoguang merged 49 commits intogo-gitea:mainfrom
bircni:feature/action-summary-view
Mar 22, 2026
Merged

Add summary to action runs view#36883
wxiaoguang merged 49 commits intogo-gitea:mainfrom
bircni:feature/action-summary-view

Conversation

@bircni
Copy link
Copy Markdown
Member

@bircni bircni commented Mar 10, 2026

When opening a run without a job in the path (/actions/runs/{run} instead of .../runs/{run}/jobs/{job}), show a run summary instead of defaulting to job 0.

  • Backend:
    If the {job} segment is missing, treat it as summary mode (jobIndex = -1). In that case, skip loading logs and only return run-level data (run + jobs). Run payload is extended with duration, triggeredAt, and triggerEvent for the summary UI.
  • Frontend:
    In summary mode, the right panel shows a short run summary (trigger, status, total duration, artifact count) and the workflow graph. The sidebar gets a “Summary” entry at the top, a divider, an “All jobs” label, then the job list. The “Workflow graph” toggle is hidden on the summary page (graph is always shown). Log loading, hash handling, and storage options are no-ops in summary mode.
grafik

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 10, 2026
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Mar 10, 2026
@bircni
Copy link
Copy Markdown
Member Author

bircni commented Mar 10, 2026

@xDarkmanx curious to hear your take on this 🙂

@bircni bircni changed the title Add summary and duration fields to action runs view Add summary to action runs view Mar 10, 2026
@bircni
Copy link
Copy Markdown
Member Author

bircni commented Mar 10, 2026

This is also a preparation for #36098

@silverwind
Copy link
Copy Markdown
Member

silverwind commented Mar 10, 2026

image

That text overlapping the line looks ugly. And I think i prefer a monochrome display like GitHub's.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a “run summary” mode to the repository Actions run view when /actions/runs/{run} is opened without a job segment, so the UI no longer defaults to job 0 and instead shows run-level information plus the workflow graph.

Changes:

  • Backend: Treat missing {job} as summary mode (jobIndex = -1), skip log/task loading, and extend the run payload with duration, triggeredAt, and triggerEvent.
  • Frontend: Add summary-mode UI (summary panel + always-on workflow graph) and adjust sidebar structure to include a “Summary” entry and “All jobs” label.
  • Localization/templates: Add required locale strings and pass them into the Vue app via data-locale-* attributes.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
web_src/js/features/repo-actions.ts Passes new summary-related locale strings into the RepoActionView app.
web_src/js/components/RepoActionView.vue Implements summary-mode behavior (no log fetching) and renders run summary + graph UI.
templates/repo/actions/view_component.tmpl Exposes new locale strings via data-locale-* attributes for the frontend.
routers/web/repo/actions/view.go Adds summary-mode routing behavior and extends the JSON response with run summary fields.
options/locale/locale_en-US.json Adds English strings for the new summary UI labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread web_src/js/components/RepoActionView.vue Outdated
Comment thread routers/web/repo/actions/view.go Outdated
bircni and others added 2 commits March 10, 2026 21:58
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Nicolas <bircni@icloud.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Nicolas <bircni@icloud.com>
@bircni
Copy link
Copy Markdown
Member Author

bircni commented Mar 10, 2026

@silverwind lets solve these issues somewhere else?
I did not implement them here

@bircni
Copy link
Copy Markdown
Member Author

bircni commented Mar 10, 2026

That text overlapping the line looks ugly. And I think i prefer a monochrome display like GitHub's.

I am 100% with you!
I removed the text, I think its not useful
The redesign should be implemented in another PR ig but I would really like that
grafik

@bircni
Copy link
Copy Markdown
Member Author

bircni commented Mar 10, 2026

@silverwind do you like this top bar better?
grafik

@silverwind
Copy link
Copy Markdown
Member

silverwind commented Mar 11, 2026

@silverwind do you like this top bar better? grafik

Yes seems good, fix contrast issues, vertical centering and increase spacing between header and value a bit.

@silverwind
Copy link
Copy Markdown
Member

The redesign should be implemented in another PR ig but I would really like that

Oh, so the graph is not from this PR but pre-existing? If that's the case, then yes, don't touch it.

@bircni
Copy link
Copy Markdown
Member Author

bircni commented Mar 12, 2026

@silverwind fixed

Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is right to keep adding if (!this.isSummaryMode), it makes the code unmaintainable.

image image

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 12, 2026
@bircni
Copy link
Copy Markdown
Member Author

bircni commented Mar 13, 2026

@wxiaoguang you were right - I refactored it 😄
Also made it more beautiful @silverwind might be happy
image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2026
@wxiaoguang wxiaoguang marked this pull request as ready for review March 21, 2026 23:51
@bircni
Copy link
Copy Markdown
Member Author

bircni commented Mar 21, 2026

It is impossible to "rerun" a single job (just a question, I haven't looked into / don't understand the origin design)

Maybe the "single job rerun" was never supported or implemented. So I will leave the problem as is.

I think you can
On the left side next to the job but only if all jobs are either cancelled or failed or in a isDone Stage

@wxiaoguang
Copy link
Copy Markdown
Contributor

It is impossible to "rerun" a single job (just a question, I haven't looked into / don't understand the origin design)

Maybe the "single job rerun" was never supported or implemented. So I will leave the problem as is.

I think you can On the left side next to the job but only if all jobs are either cancelled or failed or in a isDone Stage

Oh yes, it is in the left list, I missed it ...... the UI looks somewhat counterintuitive (no rerun button for a single job at the same place as the "summary" page), but I think it isn't really a problem.

@wxiaoguang wxiaoguang force-pushed the feature/action-summary-view branch from aac1f2a to 7f82a72 Compare March 22, 2026 00:06
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 22, 2026 00:25
@wxiaoguang wxiaoguang merged commit c854503 into go-gitea:main Mar 22, 2026
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Mar 22, 2026
@bircni bircni deleted the feature/action-summary-view branch March 22, 2026 08:58
@bircni bircni mentioned this pull request Mar 22, 2026
lunny pushed a commit that referenced this pull request Mar 22, 2026
I'd like to apply as a maintainer.

Thanks to @TheFox0x7 for the suggestion.

Merged PRs:
- #36441
- #36571
- #36603
- #36768
- #36776
- #36783
- #36876
- #36883
- #36924

Ongoing work:
- #36514
- #36752
- #36912
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 23, 2026
* giteaofficial/main:
  Add user badges (go-gitea#36752)
  Apply as maintainer (go-gitea#36947)
  Refactor storage content-type handling of ServeDirectURL (go-gitea#36804)
  Add summary to action runs view (go-gitea#36883)
  feat: Add configurable permissions for Actions automatic tokens (go-gitea#36173)
  Feature: Add button to re-run failed jobs in Actions (go-gitea#36924)
  Support dark/light theme images in markdown (go-gitea#36922)
  fix go-gitea#36463: preserve sort order of exclusive labels from template repo (go-gitea#36931)
  fix(upgrade.sh): use HTTPS for GPG key import and restore SELinux context after upgrade (go-gitea#36930)
  [skip ci] Updated translations via Crowdin
  Make container registry support Apple Container (basic auth) (go-gitea#36920)
  Fix various trivial problems (go-gitea#36921)
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 23, 2026
* origin/main:
  Update to eslint 10 (go-gitea#36925)
  Add user badges (go-gitea#36752)
  Apply as maintainer (go-gitea#36947)
  Refactor storage content-type handling of ServeDirectURL (go-gitea#36804)
  Add summary to action runs view (go-gitea#36883)
  feat: Add configurable permissions for Actions automatic tokens (go-gitea#36173)
  Feature: Add button to re-run failed jobs in Actions (go-gitea#36924)
  Support dark/light theme images in markdown (go-gitea#36922)
  fix go-gitea#36463: preserve sort order of exclusive labels from template repo (go-gitea#36931)
  fix(upgrade.sh): use HTTPS for GPG key import and restore SELinux context after upgrade (go-gitea#36930)
  [skip ci] Updated translations via Crowdin
  Make container registry support Apple Container (basic auth) (go-gitea#36920)
  Fix various trivial problems (go-gitea#36921)
  [skip ci] Updated translations via Crowdin

# Conflicts:
#	package.json
#	pnpm-lock.yaml
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Mar 25, 2026

Regression: "All jobs" is essentially unreadable on dark theme. Should probably remove color from .left-list-header.

image

@wxiaoguang
Copy link
Copy Markdown
Contributor

Regression: "All jobs" is essentially unreadable on dark theme. Should probably remove color from .left-list-header.

It it CERTAIN you blindly approved "Restyle Workflow Graph #36912" without testing it, AGAIN.

@silverwind
Copy link
Copy Markdown
Member

silverwind commented Mar 25, 2026

I did mention contrast issues in #36883 (comment) but those were apparently ignored. And I never approved this.

@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Mar 25, 2026

I did mention contrast issues in #36883 (comment) but those were apparently ignored.

It's said it has been fixed #36883 (comment). You also said "Oh, so the graph is not from this PR but pre-existing? If that's the case, then yes, don't touch it." #36883 (comment).

And I never approved this.

I approved, 2 approvals. What's the problem?

silverwind added a commit to silverwind/gitea that referenced this pull request Mar 25, 2026
- Fix `.left-list-header` unreadable on dark theme by using
  `--color-text-light-2` instead of `--color-grey`
- Fix `.graph-metrics` bullet inheriting blue color
- Improve summary block layout with horizontal flexbox
- Add dot separator between status and duration

Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 25, 2026
- Fix `.left-list-header` unreadable on dark theme by using
  `--color-text-light-2` instead of `--color-grey`
- Fix `.graph-metrics` bullet inheriting blue color
- Improve summary block layout with horizontal flexbox
- Add dot separator between status and duration

Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
@silverwind
Copy link
Copy Markdown
Member

The problematic --color-grey was never fixed. I did not check in detail.

What's the problem?

I thought you wanted to blame me for this problem.

@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Mar 25, 2026

The problematic --color-grey was never fixed. I did not check in detail.

What's the problem?

I thought you wanted to blame me for this problem.

I was just talking about "it's not right to approve a large PR without really testing it"

You approved ""Restyle Workflow Graph #36912" twice, it does contain the fix.

image

bircni pushed a commit to bircni/gitea that referenced this pull request Mar 26, 2026
- Fix `.left-list-header` unreadable on dark theme by using
  `--color-text-light-2` instead of `--color-grey`
- Fix `.graph-metrics` bullet inheriting blue color
- Improve summary block layout with horizontal flexbox
- Add dot separator between status and duration

Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants